[Docs] Out of place esimd radix sort documentation update #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
requested review from
timmiesmith,
akukanov,
dmitriy-sobolev and
adamfidel
danhoeflinger
changed the title
dcbenito
requested changes
May 14, 2024
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
documentation/library_guide/kernel_templates/esimd/radix_sort.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
force-pushed
the
dev/dhoeflin/out_of_place_docs
branch
from
8dcdbae to
40343d9
Compare
dcbenito
previously approved these changes
May 15, 2024
adamfidel
reviewed
May 15, 2024
| @@ -66,22 +101,25 @@ Parameters | |||
| +-----------------------------------------------+---------------------------------------------------------------------+ | |||
| | Name | Description | | |||
| +===============================================+=====================================================================+ | |||
| | ``q`` | SYCL* queue to submit the kernels to. | | |||
| | ``q`` | SYCL* queue to submit the kernels to. | | |||
There was a problem hiding this comment.
(Feedback based on #1559)
Suggested change
| | ``q`` | SYCL* queue to submit the kernels to. | | |
| | ``q`` | The SYCL* queue where kernels are submitted. | |
There was a problem hiding this comment.
fixed, thanks
| +-----------------------------------------------+---------------------------------------------------------------------+ | ||
| | | | | ||
| | | The sequences of elements to apply the algorithm to. | |
There was a problem hiding this comment.
(Feedback based on #1559)
Suggested change
| | | The sequences of elements to apply the algorithm to. | | |
| | | The sequences to apply the algorithm to. | |
There was a problem hiding this comment.
fixed, thanks
Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the esimd radix sort documentation with the out of place overloads which were added in #1439.
It also cleans up some minor typos and fixes the namespace in the examples to match their new home after the move.
The memory requirements and performance considerations for out of place overloads should be equivalent to the in place overloads. Out of place overloads run the same kernel code internally, it just provides different input and output sequences to the kernels to allow users to
(1) preserve input sequence order
(2) fold in a copy to an output sequence